-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Error Catch/Page #113
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments on styling, please address that and re-request for a review
|
||
return ( | ||
<Container | ||
sx={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move in-line styling to the styles file
}} | ||
> | ||
<Box | ||
sx={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
<Typography variant="h4" gutterBottom> | ||
Network Error | ||
</Typography> | ||
<Typography sx={{ mb: 4, maxWidth: '400px', textAlign: 'center' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Description
Modified front end to detect when there is a network error and to throw a new error page with the network error message and with the specified Sigma implementation.
Ticket: Epic 13: Kai Notifications, Network Error Page
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Include screenshot/video if possible.
Hardcoded a a network error in the backend, and implemented a try-catch in the front end to catch this error and to make sure that the correct error page was displayed. After the test was successful I removed the hardcoded error and returned everything to its original documentation.