Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Error Catch/Page #113

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

user10970
Copy link

Description

Modified front end to detect when there is a network error and to throw a new error page with the network error message and with the specified Sigma implementation.
Ticket: Epic 13: Kai Notifications, Network Error Page

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Include screenshot/video if possible.
Hardcoded a a network error in the backend, and implemented a try-catch in the front end to catch this error and to make sure that the correct error page was displayed. After the test was successful I removed the hardcoded error and returned everything to its original documentation.

Copy link
Contributor

@bkb-Git bkb-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on styling, please address that and re-request for a review


return (
<Container
sx={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move in-line styling to the styles file

}}
>
<Box
sx={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

<Typography variant="h4" gutterBottom>
Network Error
</Typography>
<Typography sx={{ mb: 4, maxWidth: '400px', textAlign: 'center' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants