3.9.3 #19
Merged
3.9.3 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 580b8af.
lmeier
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
This looks good to me. Note that we've very recently updated how we do trackVerified -- we combine trackVerifiedToken and trackVerified into one, in this release.
I don't think we need to upgrade at this time, just calling this out.
I'd love to also be able to run this locally in my own setup — let's continue chatting in slack to make sure I can get past all the blockers.
Thanks!
| @@ -22,9 +22,14 @@ public static void Initialize(RadarSDK sdk, string radarKey = null) | |||
| { "int", 10 }, | |||
| { "bool", true } | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
note: I see that you accidentally commited your api key above previously so I reset it @cameron-morrow-toptal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdk upgrade to 3.9.3, includes some refactors such as new structs return types to replace anonymous tuples and uses code sharing to remove duplicate xam/maui code