added maui support #18
Conversation
cameron-morrow-toptal
commented
Feb 26, 2024
cameron-morrow-toptal
commented
- changed RadarIO.Xamarin namespace to RadarIO
- changed location object from Xamarin.Essentials.Location to RadarIO.RadarLocation
| try | ||
| { | ||
| await Permissions.RequestAsync<Permissions.LocationAlways>(); | ||
|
|
There was a problem hiding this comment.
Is this the sample app sent via TestFlight?
If so, can you add 5 more buttons:
- startTrackingResponsive
- startTrackingContinuous
- stopTracking
- startTrip, like this: https://radar.com/documentation/sdk/xamarin#trip-tracking
Except using the function that takes two params: https://github.com/radarlabs/radar-sdk-xamarin/pull/18/files#diff-c5f6d14c626098f16a3db22bd3cc2d51e664bd1e31be938b38f9ee2024ad4210R167
- stopTrip
RadarIO.nuspec
Outdated
| <package> | ||
| <metadata> | ||
| <id>RadarIO.Xamarin</id> | ||
| <version>3.7.16</version> |
There was a problem hiding this comment.
Is this the version number for both Xamarin and Maui?
What versions of the Radar iOS and Android SDK's does this use?
There was a problem hiding this comment.
this is the version of the nuget package that we publish. the version of the sdks are determined by the sdk I bind in the binding libraries
| public MainPage() | ||
| { | ||
| InitializeComponent(); | ||
| Initialize(new RadarSDKImpl()); |
There was a problem hiding this comment.
Our Xamarin documentation looks like this: https://radar.com/documentation/sdk/xamarin#initialize
Does this code need to do:
using RadarIO.Maui;
using static RadarIO.Maui.RadarSingleton;
Do we need to leverage the singleton anymore?
RadarIO.nuspec
Outdated
| <package> | ||
| <metadata> | ||
| <id>RadarIO.Xamarin</id> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
Let's make this 3.7.8 since that's the version of Radar it's based on
There was a problem hiding this comment.
or actually for now - 3.7.8-beta.1
.github/workflows/nuget-publish.yml
Outdated
| msbuild /p:Configuration=Release RadarIO.Xamarin.Android | ||
| nuget pack | ||
| ./build.sh | ||
| nuget pack -version ${{ inputs.version }} |
There was a problem hiding this comment.
where does inputs.version come from?
