-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Crosscompile for Windows arm64 #22612
base: master
Are you sure you want to change the base?
Conversation
@@ -49,7 +49,7 @@ REM: Targets: x86 amd64 x64 arm arm64 | |||
IF "%*" == "x86" ( | |||
set VSARCH=x86 | |||
) ELSE IF "%*" == "arm64" ( | |||
set VSARCH=x86_arm64 | |||
set VSARCH=x64_arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here also amd64_arm64
for crosscompile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is from visual studio, the naming convention is different between the action and the compiler. i think this is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh just checked the vs batch script and seems to handle also amd64_arm64 which is the same as x64_arm64, so both options are valid 👍
Also using meson cross-compile feature will be required to avoid a sanity check error. |
never used that before. did you?
|
yes, I arrived at the same point in my fork. this is because meson is checking as if you are building for native environment. I tried in my fork but it would be easier to implement it having a local windows build environment. |
Looks like the final executable generated by the CI is for x86-64
Observations: