Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/audit log #323

Merged
merged 9 commits into from
Oct 16, 2023
Merged

Feature/audit log #323

merged 9 commits into from
Oct 16, 2023

Conversation

Bentechy66
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (99e36cb) 96.85% compared to head (7b06d01) 96.61%.
Report is 1 commits behind head on master.

❗ Current head 7b06d01 differs from pull request most recent head b3f5080. Consider uploading reports for the commit b3f5080 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   96.85%   96.61%   -0.24%     
==========================================
  Files         113      113              
  Lines        5280     5322      +42     
  Branches      282      287       +5     
==========================================
+ Hits         5114     5142      +28     
- Misses        134      146      +12     
- Partials       32       34       +2     
Files Coverage Δ
src/admin/views.py 100.00% <100.00%> (ø)
src/announcements/views.py 100.00% <100.00%> (ø)
src/authentication/views.py 100.00% <100.00%> (ø)
src/challenge/views.py 84.41% <100.00%> (ø)
src/hint/views.py 100.00% <100.00%> (ø)
src/member/views.py 100.00% <100.00%> (ø)
src/pages/views.py 100.00% <100.00%> (ø)
src/team/views.py 100.00% <100.00%> (ø)
src/backend/viewsets.py 67.60% <65.00%> (-3.37%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -37,3 +38,59 @@ def get_serializer_class(self):
if self.request.user.is_staff and not self.request.user.should_deny_admin():
return self.admin_serializer_class
return self.serializer_class


class AuditLoggedViewSet(ModelViewSet):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better as a Mixin style class?

@Bentechy66 Bentechy66 merged commit ad04c9b into master Oct 16, 2023
4 of 5 checks passed
@Bentechy66 Bentechy66 deleted the feature/audit_log branch October 16, 2023 22:19
0xAda added a commit that referenced this pull request Sep 26, 2024
* Pin to python3.10 and fix pyyaml

* backend work for leaderboard groups

* lol

* return names

* add uritemplate

* Upgrade uvicorn to use a version of websockets from this decade

* Add audit logging

---------

Co-authored-by: Ada Cooke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants