Skip to content

Commit

Permalink
Add to the word-break property support of the break-word value (CSS3)
Browse files Browse the repository at this point in the history
  • Loading branch information
@racodond
Adam Gabryś authored and racodond committed May 22, 2018
1 parent dd89446 commit d5f6b59
Show file tree
Hide file tree
Showing 15 changed files with 22 additions and 16 deletions.
3 changes: 2 additions & 1 deletion css-checks/src/test/resources/checks/common/properties/css/word-break.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
word-break: normal;
word-break: keep-all;
word-break: break-all;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
word-break: break-word;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
word-break: 10; /* Noncompliant */
}
3 changes: 2 additions & 1 deletion css-checks/src/test/resources/checks/common/properties/less/word-break.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
word-break: normal;
word-break: keep-all;
word-break: break-all;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
word-break: break-word;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
word-break: 10; /* Noncompliant */
}
3 changes: 2 additions & 1 deletion css-checks/src/test/resources/checks/common/properties/scss/word-break.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
word-break: normal;
word-break: keep-all;
word-break: break-all;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
word-break: break-word;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
word-break: 10; /* Noncompliant */
}
4 changes: 2 additions & 2 deletions css-frontend/src/main/java/org/sonar/css/model/property/standard/WordBreak.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
public class WordBreak extends StandardProperty {

public WordBreak() {
addLinks("https://drafts.csswg.org/css-text-3/#propdef-word-break");
addValidators(new IdentifierValidator("normal", "keep-all", "break-all"));
addLinks("https://www.w3.org/TR/css-text-3/#word-break-property");
addValidators(new IdentifierValidator("normal", "keep-all", "break-all", "break-word"));
}

}
3 changes: 2 additions & 1 deletion its/ruling/projects/custom/common/properties/css/word-break.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
word-break: normal;
word-break: keep-all;
word-break: break-all;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
word-break: break-word;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
word-break: 10; /* Noncompliant */
}
3 changes: 2 additions & 1 deletion its/ruling/projects/custom/common/properties/less/word-break.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
word-break: normal;
word-break: keep-all;
word-break: break-all;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
word-break: break-word;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
word-break: 10; /* Noncompliant */
}
3 changes: 2 additions & 1 deletion its/ruling/projects/custom/common/properties/scss/word-break.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
word-break: normal;
word-break: keep-all;
word-break: break-all;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
word-break: break-word;
word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
word-break: 10; /* Noncompliant */
}
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/css-line-length.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@
9,
],
'project:custom/common/properties/css/word-break.css':[
6,
7,
],
'project:custom/common/properties/css/word-spacing.css':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/css-validate-property-value.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1659,8 +1659,8 @@
10,
],
'project:custom/common/properties/css/word-break.css':[
6,
7,
8,
],
'project:custom/common/properties/css/word-spacing.css':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/less-line-length.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@
9,
],
'project:custom/common/properties/less/word-break.less':[
6,
7,
],
'project:custom/common/properties/less/word-spacing.less':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/less-prefer-single-line-comments.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1917,8 +1917,8 @@
10,
],
'project:custom/common/properties/less/word-break.less':[
6,
7,
8,
],
'project:custom/common/properties/less/word-spacing.less':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/less-validate-property-value.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1652,8 +1652,8 @@
10,
],
'project:custom/common/properties/less/word-break.less':[
6,
7,
8,
],
'project:custom/common/properties/less/word-spacing.less':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/scss-line-length.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@
9,
],
'project:custom/common/properties/scss/word-break.scss':[
6,
7,
],
'project:custom/common/properties/scss/word-spacing.scss':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/scss-prefer-single-line-comments.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1934,8 +1934,8 @@
10,
],
'project:custom/common/properties/scss/word-break.scss':[
6,
7,
8,
],
'project:custom/common/properties/scss/word-spacing.scss':[
8,
Expand Down
2 changes: 1 addition & 1 deletion its/ruling/tests/src/test/expected/scss-validate-property-value.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1611,8 +1611,8 @@
10,
],
'project:custom/common/properties/scss/word-break.scss':[
6,
7,
8,
],
'project:custom/common/properties/scss/word-spacing.scss':[
8,
Expand Down

0 comments on commit d5f6b59

Please sign in to comment.