Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix flavor to ironic resource class conversion #511

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: fix flavor to ironic resource class conversion #511

merged 2 commits into from
Nov 21, 2024

Conversation

nicholaskuechler
Copy link
Contributor

@nicholaskuechler nicholaskuechler commented Nov 21, 2024 •
edited
Loading

Resource class is coming in to ironic as:

| resource_class         | baremetal.gp2.small                                                                                                                                                                 |

But it should be baremetal.gp2small

@nicholaskuechler nicholaskuechler marked this pull request as ready for review November 21, 2024 19:47
mfencik
mfencik approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mfencik mfencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholaskuechler nicholaskuechler added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit f277ab6 Nov 21, 2024
26 checks passed
@nicholaskuechler nicholaskuechler deleted the enroll-20241121-1 branch November 21, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfencik mfencik mfencik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaskuechler @mfencik