-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor mech driver #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeouts were recently added to prevent the undersync workflow from hanging indefinitely. It might be a good idea to do that here, too.
237e5ae
to
af84243
Compare
This is implemented too |
python/neutron-understack/neutron_understack/neutron_understack_mech.py
Outdated
Show resolved
Hide resolved
python/neutron-understack/neutron_understack/neutron_understack_mech.py
Outdated
Show resolved
Hide resolved
python/neutron-understack/neutron_understack/neutron_understack_mech.py
Outdated
Show resolved
Hide resolved
827940f
to
6d28c47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM. Added few more suggestions for missing docstrings and type hints.
One more (optional) idea - consider updating #update_nautobot
to return an instance of UUID
instead of plain string, this way we add another layer of data validation which would be better than a docstring promise of returning string that happens to contain uuid.
python/neutron-understack/neutron_understack/neutron_understack_mech.py
Outdated
Show resolved
Hide resolved
python/neutron-understack/neutron_understack/neutron_understack_mech.py
Outdated
Show resolved
Hide resolved
6d28c47
to
7289297
Compare
that's a good idea, implemented |
After this is tested and merged, I'm aware we can do a better cleanup in workflows as we won't need undersync_device workflow anymore.
This PR needs another change in Nautobot prep_switch_interface job as from now on we can use connected_interface_uuid instead of mac_address, so please leave merging to me.