Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): device name param was removed #331

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ repos:
args:
- --schemafile
- https://raw.githubusercontent.com/argoproj/argo-workflows/master/api/jsonschema/schema.json
files: "workflows/argo-events/(sensors|workflowtemplates)/.*.(yml|yaml)$"
files: "workflows/argo-events/workflowtemplates/.*.(yml|yaml)$"
- repo: https://github.com/igorshubovych/markdownlint-cli
rev: v0.37.0
hooks:
Expand Down
31 changes: 20 additions & 11 deletions docs/component-understack-workflows.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
# Understack Workflows

This is the Kubernetes installation of the Argo Workflows
and their associated support bits to add the actual workflows,
sensors and triggers into a Kubernetes cluster.
Understack Workflows is a collection of code, scripts, container definitions
centered around [Argo Workflows][argo-wf] to drive automated operations
based on events and other triggers in the system.

Due to the scoping of resources into different namespaces, this
must also be split into multiple namespaces.
Due to the scoping of resources into different namespaces in the deployment
it is also split into multiple namespaces.

This code lives in `apps/understack-workflows` of this repo.

Specifics about the workflows can be seen in the Workflows
Specifics about each workflow can be seen in the Workflows
section.

## eventsource-openstack
## workflows/openstack

This is where Kubernetes manifests are stored for interacting with
resources in the `openstack` namespace.

The resources managed here are:

Expand All @@ -34,11 +35,19 @@ execute a Workflow.
1. An [Argo Events][argo-events] Sensors and Triggers that
execute workflows.

## workflowtemplates
## workflows/argo-events

This is where Kubernetes manifests are stored for the actual workflow
templates.

1. A Kubernetes Role Binding allowing the `sensor-submit-workflow`
the access it needs to run Workflows.
1. A number of Workflow Templates.
1. [Workflow Templates](./workflows/argo-events.md)

## python/understack-workflows

The code that is installed into the `ironic-nautobot-client` container
which is used for many of the workflows lives here.

[argo-events]: <https://argoproj.github.io/argo-events/>
[argo-wf]: <https://argo-workflows.readthedocs.io/en/latest/>
Expand Down
4 changes: 0 additions & 4 deletions workflows/argo-events/sensors/nb-oob-interface-update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ spec:
src:
dataKey: body.data.device.id
dependencyName: nautobot-dep
- dest: spec.arguments.parameters.2.value
src:
dataKey: body.data.device.name
dependencyName: nautobot-dep
source:
resource:
apiVersion: argoproj.io/v1alpha1
Expand Down