Skip to content

Commit

Permalink
Add pyright type checking for understack-workflows python code
Browse files Browse the repository at this point in the history
Note that we hard-code python deps because the pre-commit checker operates in
its own independent venv and cannot access the deps that poetry installs.  This
seems broken, as it allows the versions to drift.  However it is better than
nothing.
  • Loading branch information
Steve Keay authored and cardoe committed Nov 13, 2024
1 parent eecc3ca commit 1719ad5
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,19 @@ repos:
rev: 38.114.0
hooks:
- id: renovate-config-validator
- repo: https://github.com/RobertCraigie/pyright-python
rev: v1.1.387
hooks:
- id: pyright
files: '^python/understack-workflows/'
args: ["--threads"]
additional_dependencies:
- "kubernetes"
- "pydantic"
- "pynautobot"
- "pytest"
- "pytest_lazy_fixtures"
- "python-ironicclient"
- "requests"
- "sushy"
- "types-requests"

0 comments on commit 1719ad5

Please sign in to comment.