nova_flavors: fix punctuation handling in nova resource class

rackerlabs · Nov 25, 2024 · 0050224 · 0050224
1 parent 0f25402
commit 0050224
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/python/understack-flavor-matcher/flavor_matcher/flavor_spec.py b/python/understack-flavor-matcher/flavor_matcher/flavor_spec.py
@@ -59,7 +59,7 @@ def baremetal_nova_resource_class(self):
 
         https://docs.openstack.org/ironic/latest/install/configure-nova-flavors.html
         """
-        converted_name = re.sub(r"[^\w]", "", self.stripped_name).upper()
+        converted_name = re.sub(r"[^\w]", "_", self.stripped_name).upper()
         return f"resources:CUSTOM_BAREMETAL_{converted_name}"
 
     @property

diff --git a/python/understack-flavor-matcher/tests/test_flavor_spec.py b/python/understack-flavor-matcher/tests/test_flavor_spec.py
@@ -329,7 +329,8 @@ def test_memory_gib(valid_yaml):
 def test_baremetal_nova_resource_class(valid_yaml):
     flv = FlavorSpec.from_yaml(valid_yaml)
     assert (
-        flv.baremetal_nova_resource_class == "resources:CUSTOM_BAREMETAL_GP2ULTRAMEDIUM"
+        flv.baremetal_nova_resource_class
+        == "resources:CUSTOM_BAREMETAL_GP2_ULTRAMEDIUM"
     )