Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define xref methods only for emacs versions >= 25 (possibly fixes xref support) #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vibhavp
Copy link
Contributor

@vibhavp vibhavp commented Sep 22, 2016

No description provided.

@Wilfred
Copy link
Member

Wilfred commented Dec 4, 2016

I've pushed an xref_support branch with the conflicts merged. There's some code duplication though, e.g. racer--xref-make-definitions is manually calling racer rather than using racer--call.

If you'd like to take a look, that would be a great help. I do want us to merge this, so I will get around to it, but it's not currently top of my list.

@vibhavp
Copy link
Contributor Author

vibhavp commented Dec 7, 2016

LGTM

@Hi-Angel
Copy link
Contributor

@Wilfred so, should xref work at the moment? For me calling xref-find-definitions for the same symbol where racer-find-definition worked results in a prompt for a TAGS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants