feat: update dependencies and replace SCSS variables with CSS #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-romaniuk
force-pushed
the
rg-dev/redwood.master
branch
from
a46140b to
a93acc5
Compare
ihor-romaniuk
commented
Jan 8, 2025
src/index.jsx
Outdated
| @@ -11,7 +11,7 @@ import ReactDOM from 'react-dom'; | |||
| import { Route, Routes, Outlet } from 'react-router-dom'; | |||
|
|
|||
| import Header from '@edx/frontend-component-header'; | |||
| import { FooterSlot } from '@edx/frontend-component-footer'; | |||
| import Footer from '@edx/frontend-component-footer'; | |||
There was a problem hiding this comment.
It is necessary to return the ability to use FooterSlot
The previous version of `frontend-slot-footer` had a peer dependency of `^14.0.0`, which caused problems for some methods of installing forked footers. This updates to a version of `frontend-slot-footer` that allows for *any* version of `frontend-component-footer` in the peer dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: