feat: [AXM-355] add information about offline metadata to course blocks #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiedielnitsevIvan
changed the title
NiedielnitsevIvan
force-pushed
the
NiedielnitsevIvan/AXM-355/feature/Include-information-about-offlline-metadata-to-course-blocks
branch
from
90dc1fa to
a151cf8
Compare
NiedielnitsevIvan
changed the base branch from
mob-develop
to
NiedielnitsevIvan/AXM-349/feature/Implement-media-generation-for-problem-xblock
NiedielnitsevIvan
force-pushed
the
NiedielnitsevIvan/AXM-355/feature/Include-information-about-offlline-metadata-to-course-blocks
branch
2 times, most recently
from
a145bc0 to
fac1fd0
Compare
NiedielnitsevIvan
changed the title
NiedielnitsevIvan
force-pushed
the
NiedielnitsevIvan/AXM-355/feature/Include-information-about-offlline-metadata-to-course-blocks
branch
from
fac1fd0 to
1cc1fe8
Compare
NiedielnitsevIvan
force-pushed
the
NiedielnitsevIvan/AXM-349/feature/Implement-media-generation-for-problem-xblock
branch
from
b3114b2 to
450e04a
Compare
NiedielnitsevIvan
force-pushed
the
NiedielnitsevIvan/AXM-355/feature/Include-information-about-offlline-metadata-to-course-blocks
branch
from
1cc1fe8 to
1348ea3
Compare
GlugovGrGlib
changed the base branch from
NiedielnitsevIvan/AXM-349/feature/Implement-media-generation-for-problem-xblock
to
mob-develop
GlugovGrGlib
changed the base branch from
mob-develop
to
NiedielnitsevIvan/AXM-542/feature/Render-xblock-in-CMS
…locks when publishing courses
GlugovGrGlib
force-pushed
the
NiedielnitsevIvan/AXM-355/feature/Include-information-about-offlline-metadata-to-course-blocks
branch
from
633c3fd to
3abe52d
Compare
| @@ -155,6 +159,13 @@ def listen_for_course_publish(sender, course_key, **kwargs): # pylint: disable= | |||
| # Send to a signal for catalog info changes as well, but only once we know the transaction is committed. | |||
| transaction.on_commit(lambda: emit_catalog_info_changed_signal(course_key)) | |||
|
|
|||
| if is_offline_mode_enabled(course_key): | |||
| requests.post( | |||
There was a problem hiding this comment.
We need to discuss this with somebody from AXIM: @GlugovGrGlib @NiedielnitsevIvan TBD
|
|
||
| If offline content is available for the block, adds the offline download data to the block info. | ||
| """ | ||
| for block_id, block_info in blocks_info_data.items(): |
There was a problem hiding this comment.
Can we optimize it by filtering only for supported offline types?
TBD in follow up
| @@ -9,5 +9,5 @@ | |||
| MATHJAX_CDN_URL = f'https://cdn.jsdelivr.net/npm/mathjax@{MATHJAX_VERSION}/MathJax.js' | |||
| MATHJAX_STATIC_PATH = os.path.join('assets', 'js', f'MathJax-{MATHJAX_VERSION}.js') | |||
|
|
|||
| DEFAULT_OFFLINE_SUPPORTED_XBLOCKS = ['problem'] | |||
| DEFAULT_OFFLINE_SUPPORTED_XBLOCKS = ['html'] | |||
There was a problem hiding this comment.
Does it intendant or a merge conflict?
| # .. toggle_implementation: CourseWaffleFlag | ||
| # .. toggle_default: False | ||
| # .. toggle_description: This feature toggle enables the offline mode course | ||
| # content generation for mobile devices. |
There was a problem hiding this comment.
Open edX mobile applications
| from .views import SudioCoursePublishedEventHandler | ||
|
|
||
| urlpatterns = [ | ||
| path('handle_course_published', SudioCoursePublishedEventHandler.as_view(), name='handle_course_published'), |
There was a problem hiding this comment.
It's definitely required to write up rationale for a separate Open edX application for offline support, as I believe we would have hard time merging it without ADR unfortunately.
GlugovGrGlib
merged commit 9b14946
into
NiedielnitsevIvan/AXM-542/feature/Render-xblock-in-CMS
37 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: [AXM-349] Implement media generation for problem xblock