feat: [AXIMST-490] display render errors #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/display-render-errors
branch
3 times, most recently
from
bae60ac to
22a3bce
Compare
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/display-render-errors
branch
from
22a3bce to
e343bbd
Compare
monteri
reviewed
Feb 15, 2024
cms/djangoapps/contentstore/utils.py
Outdated
| return validation_json['messages'] | ||
|
|
||
|
|
||
| def get_render_error(request, xblock): |
There was a problem hiding this comment.
Maybe we can call it get_xblock_render_error and the function that is inside will be called get_xblock_render_error_context.
This will allow to put the inner function outside and clarify the idea behind these two functions.
There was a problem hiding this comment.
I don't think that we need to move out this function, it will be used only here.
Renamed
cms/djangoapps/contentstore/utils.py
Outdated
Comment on lines
2190
to
2199
| render_error = "" | ||
| try: | ||
| block = _load_preview_block(request, xblock) | ||
| preview_view = AUTHOR_VIEW if has_author_view(block) else STUDENT_VIEW | ||
| render_context = get_render_context(request, block) | ||
| block.render(preview_view, render_context) | ||
| except Exception as exc: # pylint: disable=broad-except | ||
| render_error = str(exc) | ||
|
|
||
| return render_error |
There was a problem hiding this comment.
Suggested change
| render_error = "" | |
| try: | |
| block = _load_preview_block(request, xblock) | |
| preview_view = AUTHOR_VIEW if has_author_view(block) else STUDENT_VIEW | |
| render_context = get_render_context(request, block) | |
| block.render(preview_view, render_context) | |
| except Exception as exc: # pylint: disable=broad-except | |
| render_error = str(exc) | |
| return render_error | |
| try: | |
| block = _load_preview_block(request, xblock) | |
| preview_view = AUTHOR_VIEW if has_author_view(block) else STUDENT_VIEW | |
| render_context = get_render_context(request, block) | |
| block.render(preview_view, render_context) | |
| except Exception as exc: # pylint: disable=broad-except | |
| return str(exc) | |
| return "" |
ruzniaievdm
added a commit
that referenced
this pull request
Feb 22, 2024
* feat: [AXIMST-490] display render errors * fix: resolve discussions
ruzniaievdm
added a commit
that referenced
this pull request
Mar 28, 2024
* feat: [AXIMST-490] display render errors * fix: resolve discussions
ruzniaievdm
added a commit
that referenced
this pull request
Apr 4, 2024
* feat: [AXIMST-490] display render errors * fix: resolve discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-490