Update libraries with latest #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 14, 2020 22:47
…e code to adjust with deprecated methods
rabelenda
reviewed
Jan 21, 2021
| url: ${MYSQL_URL:jdbc:mysql://mysql/onyx} | ||
| username: ${MYSQL_USERNAME:onyx} | ||
| password: ${MYSQL_PASSWORD:onyx} | ||
| autoconfigure: |
There was a problem hiding this comment.
Any particular reason to disable security?
|
|
||
| WORKDIR /opt/onyx-scheduler | ||
|
|
||
| COPY target/onyx-scheduler.jar /opt/onyx-scheduler/onyx-scheduler.jar | ||
|
|
||
| EXPOSE 8080 | ||
| EXPOSE 28080 |
There was a problem hiding this comment.
Any particular reason to change the default port?
| @@ -34,7 +34,7 @@ If you want to run it with a provided mysql database which already contains quar | |||
| ####Docker preconditions | |||
| - [Docker installed](https://docs.docker.com/installation/) | |||
|
|
|||
| A `Dockerfile` is provided so if you want to build it (after running `mvn package`) you can do something like `docker build -t onyx-scheduler .` and then `docker run -p 8080:8080 onyx-scheduler` to run the container. If you use [boot2docker](http://boot2docker.io/) remember to use the docker ip (`boot2docker ip` will display it) instead of localhost from the host machine to access the API. | |||
| A `Dockerfile` is provided so if you want to build it (after running `mvn package`) you can do something like `docker build -t onyx-scheduler .` and then `docker run -e SPRING_PROFILES_ACTIVE=mysql-jobstore -e MYSQL_URL="jdbc:mysql://host.docker.internal:3306/onyx" -e MYSQL_USERNAME=onyx -e MYSQL_PASSWORD='onyx' -p 8080:8080 onyx-scheduler` to run the container. If you use [boot2docker](http://boot2docker.io/) remember to use the docker ip (`boot2docker ip` will display it) instead of localhost from the host machine to access the API. | |||
There was a problem hiding this comment.
Any reason to be explicit in all environment variables? I would rather prefer keeping the example simple and used default provided options, and users can later on (if they need) how to change any of the provided settings. Another option is leaving the simple example and then add some section on how to change the default configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.