Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements these 2 features which essentially deprecate two settings:
auth_oauth2.jwks_url
and its corresponding erlang config entry #12239management.metadata_url
and move it toauth_oauth2.discovery_endpoint_path
#12237This PR adds the new settings while keeping the old ones until 4.2.x when they will be removed.
If the user configures the old and the new setting, RabbitMQ will take the value from the new setting
If the user configures the only the old setting, RabbitMQ uses it.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyRelease note
It should be mentioned in the release notes these two changes and the fact that users currently using
auth_oauth2.jwks_url
and/ormanagement.oauth_metadata_url
they are affected and they should modify their configuration.Any reference to
auth_oauth2.jwks_url
should be renamed toauth_oauth2.jwks_uri
. Likewise any reference in the legacy schema should be renamed to. i..ekey_config.jwks_url
tokey_config.jwks_uri
.Any reference to
management.oauth_metadata_url
should be removed and instead configure theauth_oauth2.discovery_endpoint_params
accordingly. There is a section in the docs that cover this in detail.cc @pstack2021