Add prometheus label "raft_cluster" to non-QQ raft metrics (backport #12148) (backport #12216) #12217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
By default Ra will use the cluster name as the metrics key. Currently
atom values are ignored by the prometheus plugin's tag rendering
functions, so if you have a QQ and Khepri running and request the
`/metrics/per-object` or `/metrics/detailed` endpoints you'll see values
that don't have labels set for the `ra_metrics` metrics:
# TYPE rabbitmq_raft_term_total counter
# HELP rabbitmq_raft_term_total Current Raft term number
rabbitmq_raft_term_total{vhost="/",queue="qq"} 9
rabbitmq_raft_term_total 10
With this change we map the name of the Ra cluster to a "raft_cluster"
tag, so instead an example metric might be:
# TYPE rabbitmq_raft_term_total counter
# HELP rabbitmq_raft_term_total Current Raft term number
rabbitmq_raft_term_total{vhost="/",queue="qq"} 9
rabbitmq_raft_term_total{raft_cluster="rabbitmq_metadata"} 10
This affects metrics for Khepri and the stream coordinator.
(cherry picked from commit 512f883)
(cherry picked from commit 983ac8c)
the-mikedavis
force-pushed
the
mergify/bp/v3.13.x/pr-12216
branch
from
f1a2605
to
bd7db6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
<<"raft_cluster">>tag for ra_metrics emitted the stream coordinator and Khepri. By default Ra sets the cluster name as themetrics_key(if not set in config, like it is for QQs). The prometheus plugin ignores atoms that aren't protocol names when rendering labels so these cluster name values disappear. We can convert them into a map#{<<"raft_cluster">> => atom_to_binary(ClusterName, utf8)}to render properly.Before:
After:
Connects #9665
Connects #12142
This is an automatic backport of pull request #12148 done by Mergify.
This is an automatic backport of pull request #12216 done by Mergify.