Fix issue with sparse reading a segment that is being modified. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a sparse read detects a modified segment and re-initialises it is possible that the segment will again be modified before the second read attempt. It is not necessary in this case to check if the segment has been modified as the read plan would have been generated before the segment was re-initialised so this commit introduces a new ra_log_segment:read_sparse_no_checks function that skips the modified check to avoid a crash.
kjnilsson
force-pushed
the
read-plan-modified-fix
branch
from
3c4917b to
87ea602
Compare
the-mikedavis
approved these changes
Jan 21, 2025
| @@ -319,6 +321,17 @@ read_sparse(#state{index = Index, | |||
| read_sparse0(Fd, Indexes, Index, Cache0, Acc, AccFun, 0) | |||
There was a problem hiding this comment.
To cut down on duplication a bit read_sparse could be implemented in terms of read_sparse_no_checks, eh?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sparse read detects a modified segment and re-initialises it is possible that the segment will again be modified before the second read attempt. It is not necessary in this case to check if the segment has been modified as the read plan would have been generated before the segment was re-initialised so this commit introduces a new ra_log_segment:read_sparse_no_checks function that skips the modified check to avoid a crash.