Output CSS generated by Customizer inline #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got a proof of concept working on https://raamdev.com/ but there's still something wrong with saving the theme mod when saving the customizer. I need to dig into that a bit more. I also need to work on a plan for backwards compatibility (i.e., upgrading from the previous version of the theme to this new approach should be seamless). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a work in progress.
The current method of outputting CSS generated by the theme options in the Customizer uses Admin AJAX. This is not compatible with caching and is an unnecessary performance bottleneck.
Instead of dynamically generating the needed CSS on-the-fly via Admin AJAX, let's store the generated CSS in a theme mod, then output the CSS inline via
wp_add_inline_style().Addresses #305.