Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en_US.inc #55

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Update en_US.inc #55

merged 1 commit into from
Nov 8, 2024

Conversation

MiMoHo
Copy link
Contributor

@MiMoHo MiMoHo commented Nov 6, 2024

Minor improvements to upper/lower cases in English localization.

$labels['preference_compose_subject_exact'] = 'Is one of the recipients';
$labels['preference_compose_subject_always'] = 'Always enable default identity';
$labels['preference_compose_subject_domain'] = 'uses same domain as one of the recipients';
$labels['preference_compose_subject_exact'] = 'is one of the recipients';
$labels['preference_compose_subject_never'] = 'Never enable automatically';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one starting with an uppercase character while others were lowercased? I don't have a strong preference (uppercase for menu items seemed OK to me), but I think it should stay consistent in any case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the answer builds a complete sentence with the setting's function, it makes sense to showcase this by lowercase. When the answer is an own sentence, this is indicated by starting with uppercase. This helps identifying that the answer is not directly related to the setting as enabling does not come down to the fact whether or not "one of the identities is..." but – as I understand – the default identity or, respectively, the plugin is (never) enabled independent from condition in line 10. Maybe one could specify in line 14 "Never enable custom address automatically" for a swift clarification.
From my understanding, it would be more clarifying when function of line 11 and 14 are not related to line 10, so maybe they should rather be a triple-toggle setting together with condition of line 10. When the option "Enable when one of my identities" is enabled, it could trigger a secondary option with settings specified in line 12+13.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see your point. Let's go with this 👍

@r3c r3c merged commit 4bd9291 into r3c:master Nov 8, 2024
2 checks passed
@r3c
Copy link
Owner

r3c commented Nov 8, 2024

FYI this improvement as well as #54 are both available in release 1.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants