chore(devnet): add sandbox & test contracts with drink #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: refactor: general # This is the commit message #2: init # This is the commit message #3: begin refactor # This is the commit message #4: refactor: error handling # This is the commit message #5: tests: add error handling tests # This is the commit message #6: WIP # This is the commit message #7: finalise error handling # This is the commit message #8: refactor: easier review
Co-authored-by: Frank Bell <[email protected]>
Daanvdplas
reviewed
Sep 12, 2024
Daanvdplas
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Looking good. I think we should be able to abstract the complexities away much more. The developers should be able to get a lot of info on how to use this test suite, thats it.
I think we should not put too much focus on this right now before we have the psp22 example to a good state. Then we can have better judgement on how to move forward with the this pop-drink / sandbox
chungquantin
added
ready-for-final-review
and removed
ready-for-high-level-review
labels
chungquantin
changed the base branch from
main
to
chungquantin/feat-psp22_with_drink
Co-authored-by: Daan van der Plas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the
pop_drink::Sandboxstruct for the Pop Network runtimes (located inpop-node/runtime) required for the quasi testing withdrink.This PR creates a
pop-sandboxcrate that implements thepop-drink::Sandboxruntime environment for theDevnet=>DevnetSandbox.In the context of quasi-testing with pop-drink, a sandbox refers to an isolated runtime environment that simulates the behavior of a full node, without requiring an actual node. It can emulate key processes (where runtime pallets are involved) such as block initialization, execution, and block finalization.
Tasks
release) Publishpop-drinkcrate to registry.release) Publishpop-sandboxcrate to registry.DevnetSandboximplementation inpop-sandboxpop-sandboxcrate.drinktest: feat: psp22 trait contract example with drink tests #300References