-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): add ismp feature to CI, and choosing runtime for release #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
[sc-1326] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## peter/feat-add-ismp #276 +/- ##
========================================================
+ Coverage 10.47% 51.47% +40.99%
========================================================
Files 35 48 +13
Lines 2615 4894 +2279
Branches 2615 4894 +2279
========================================================
+ Hits 274 2519 +2245
+ Misses 2339 2326 -13
- Partials 2 49 +47 |
evilrobot-01
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Daanvdplas
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #270
Note: 270 is the base branch. Please only review:
No other files changed.
Updates the CI to also build the runtimes with
--features ismp
enabled. It also modifies the release CI to only build one selected runtime or the runtime for a release (see below). If the runtime is devnet, it will build the node with--features ismp
.This means the release CI will now only build ONE runtime. Considering this is for releases, I do not see a reason we would need to build several runtimes. A testnet and mainnet release should be distinct. There is no reason to have a devnet release. There is also the option for
none
, which skips the srtool build altogether.Build Runtime on Release
When a release is published, the CI will build that specific runtime only. This requires that the release name abides by a specific format. This format requires the runtime name as the prefix:
The CI's running can be confirmed here:
release.yml
ci.yml