Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): add ismp feature to CI, and choosing runtime for release #276

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

peterwht
Copy link
Collaborator

@peterwht peterwht commented Sep 11, 2024

Related: #270
Note: 270 is the base branch. Please only review:

  • .github/workflows/ci.yml
  • .github/workflows/release.yml

No other files changed.

Updates the CI to also build the runtimes with --features ismp enabled. It also modifies the release CI to only build one selected runtime or the runtime for a release (see below). If the runtime is devnet, it will build the node with --features ismp.

This means the release CI will now only build ONE runtime. Considering this is for releases, I do not see a reason we would need to build several runtimes. A testnet and mainnet release should be distinct. There is no reason to have a devnet release. There is also the option for none, which skips the srtool build altogether.

Screenshot 2024-09-13 at 4 04 03 PM

Build Runtime on Release

When a release is published, the CI will build that specific runtime only. This requires that the release name abides by a specific format. This format requires the runtime name as the prefix:

<runtime_name_prefix>-<*can be whatever>
// testnet-v0.1.0
// devnet-v0.1.0
// mainnet-v0.1.0

The CI's running can be confirmed here:
release.yml

ci.yml

@peterwht peterwht mentioned this pull request Sep 11, 2024
@peterwht peterwht changed the base branch from main to peter/feat-add-ismp September 11, 2024 02:01
@peterwht
Copy link
Collaborator Author

[sc-1326]

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (6cd981e) to head (f3e2485).
Report is 5 commits behind head on peter/feat-add-ismp.

@@                   Coverage Diff                    @@
##           peter/feat-add-ismp     #276       +/-   ##
========================================================
+ Coverage                10.47%   51.47%   +40.99%     
========================================================
  Files                       35       48       +13     
  Lines                     2615     4894     +2279     
  Branches                  2615     4894     +2279     
========================================================
+ Hits                       274     2519     +2245     
+ Misses                    2339     2326       -13     
- Partials                     2       49       +47     

see 25 files with indirect coverage changes

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Show resolved Hide resolved
@evilrobot-01 evilrobot-01 merged commit b9619b2 into peter/feat-add-ismp Sep 19, 2024
4 checks passed
@evilrobot-01 evilrobot-01 deleted the peter/feat-add-ismp-ci branch September 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants