Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: various improvements and fixes #243

Merged
merged 15 commits into from
Aug 29, 2024

Conversation

evilrobot-01
Copy link
Collaborator

@evilrobot-01 evilrobot-01 commented Aug 29, 2024

Various fixes and improvements whilst reviewing #238

Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@peterwht peterwht merged commit da62fc2 into al3mart/chore-registration Aug 29, 2024
9 checks passed
@peterwht peterwht deleted the frank/chore-registration branch August 29, 2024 16:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.84211% with 10 lines in your changes missing coverage. Please review.

Project coverage is 9.99%. Comparing base (bec2216) to head (2ac89b3).
Report is 1 commits behind head on al3mart/chore-registration.

Files with missing lines Patch % Lines
node/src/chain_spec.rs 81.39% 5 Missing and 3 partials ⚠️
node/src/command.rs 0.00% 2 Missing ⚠️
@@                      Coverage Diff                      @@
##           al3mart/chore-registration    #243      +/-   ##
=============================================================
+ Coverage                        7.46%   9.99%   +2.53%     
=============================================================
  Files                              34      34              
  Lines                            2453    2521      +68     
  Branches                         2453    2521      +68     
=============================================================
+ Hits                              183     252      +69     
+ Misses                           2270    2266       -4     
- Partials                            0       3       +3     
Files with missing lines Coverage Δ
runtime/mainnet/src/lib.rs 16.22% <100.00%> (+10.75%) ⬆️
runtime/testnet/src/lib.rs 3.89% <ø> (ø)
node/src/command.rs 0.00% <0.00%> (ø)
node/src/chain_spec.rs 11.25% <81.39%> (+11.25%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants