-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: build chain extension method #121
refactor: build chain extension method #121
Conversation
An alternative implementation which keeps things simpler imo, taking advantage of scopes: ee4d499
|
Could you also add the contract size in the description of the PR after the changes made (with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, think there are a few final possible improvements and then should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice and clean! One final improvement suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your patience! This will be a very important piece to everything that needs to be built out, so great to have such a tidy implementation.
I think something went wrong when merging 'daan/api' because the helper functions are now not being used in the fungibles apis. |
…actor-feat-assets' into pr/121
@Daanvdplas Rebased. Should be ok now. Can you check it again? |
Good work @chungquantin! |
Co-authored-by: Daan van der Plas <[email protected]> Co-authored-by: Daanvdplas <[email protected]>
Link to discussion: #71 (comment)
Contract size: Original wasm size: 31.2K, Optimized: 7.5K