feat: pop drink #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: format with pop-node config
refactor: repo structure
crates/pop-drink/src/lib.rs
Outdated
| @@ -0,0 +1,13 @@ | |||
| pub use drink::*; | |||
| pub use ink_sandbox::api::{assets_api::AssetsAPI}; | |||
There was a problem hiding this comment.
Perhaps export all the apis available under mod api, provided it doesnt clash with drink?
| @@ -0,0 +1,13 @@ | |||
| pub use drink::*; | |||
There was a problem hiding this comment.
There are quite a few functions in the examples tests which can be moved here to the crate root, so that they can be used across all example contracts and more importantly, all dev contracts.
There was a problem hiding this comment.
Yes this was definitely the plan. Wanted to see whether we were happy with them first, before providing them to devs. Which we now are
chungquantin
requested changes
Sep 30, 2024
…ives_conversion refactor: pop primitives conversion
fix: public methods documentation
4 tasks
docs: drink
feat: runtime error
Daanvdplas
force-pushed
the
daan/feat-assets
branch
from
17485c6
to
b735c02
Compare
Daanvdplas
commented
Oct 18, 2024
| @@ -28,7 +28,7 @@ pub mod devnet { | |||
| pub use crate::error::*; | |||
|
|
|||
| pub mod v0 { | |||
| pub use pop_api::primitives::v0::{self, *}; | |||
| pub use pop_api::primitives::v0::{self, Error as ApiError, *}; | |||
There was a problem hiding this comment.
Is this used somewhere? Line 34 imports it as v0::Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up the repo for pop drink.