Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test for pop test contract #70

Merged
merged 12 commits into from
Mar 22, 2024
Merged

test: add unit test for pop test contract #70

merged 12 commits into from
Mar 22, 2024

Conversation

brunopgalvao
Copy link
Collaborator

Add unit test for pop test contract.

@brunopgalvao brunopgalvao changed the title (test: pop test contract) add unit test for pop test contract (test: pop test contract) add unit test for pop test contract Mar 19, 2024
@brunopgalvao brunopgalvao changed the title (test: pop test contract) add unit test for pop test contract test: add unit test for pop test contract Mar 19, 2024
@Daanvdplas Daanvdplas requested a review from weezy20 March 20, 2024 10:33
Daanvdplas
Daanvdplas requested changes Mar 21, 2024
View reviewed changes
src/engines/contract_engine.rs Outdated Show resolved Hide resolved
src/engines/contract_engine.rs Outdated Show resolved Hide resolved
@evilrobot-01 evilrobot-01 self-requested a review March 21, 2024 12:33
Daanvdplas
Daanvdplas approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick which would be nice to modify

src/engines/contract_engine.rs Outdated Show resolved Hide resolved
@brunopgalvao brunopgalvao merged commit 2458c20 into main Mar 22, 2024
1 check passed
@brunopgalvao brunopgalvao deleted the bruno/test-pop-test-contract branch March 22, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilrobot-01 evilrobot-01 evilrobot-01 left review comments

@Daanvdplas Daanvdplas Daanvdplas approved these changes

@AlexD10S AlexD10S AlexD10S approved these changes

@weezy20 weezy20 weezy20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brunopgalvao @weezy20 @AlexD10S @evilrobot-01 @Daanvdplas