Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration openzeppelin evm template #284

Merged
merged 19 commits into from
Nov 8, 2024
Merged

feat: integration openzeppelin evm template #284

merged 19 commits into from
Nov 8, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Aug 16, 2024

PR to support OZ EVM template: https://github.com/OpenZeppelin/polkadot-runtime-templates/tree/main/evm-template

To support EVM chains in Zombienet, the config file includes force_decorator = "generic-evm". When this field is present, pop injects evm_based = true to ensure compatibility with Zombienet-SDK after the recent fix: paritytech/zombienet-sdk#256

@AlexD10S AlexD10S changed the base branch from main to alex/refactor-releases August 16, 2024 11:52
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 84.68468% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.61%. Comparing base (582db18) to head (4890164).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-parachains/src/new_parachain.rs 67.74% 4 Missing and 6 partials ⚠️
crates/pop-parachains/src/up/mod.rs 0.00% 1 Missing and 3 partials ⚠️
crates/pop-cli/src/commands/new/parachain.rs 75.00% 1 Missing ⚠️
crates/pop-common/src/templates/extractor.rs 66.66% 0 Missing and 1 partial ⚠️
crates/pop-contracts/src/new.rs 50.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   70.32%   70.61%   +0.28%     
==========================================
  Files          53       54       +1     
  Lines        9098     9228     +130     
  Branches     9098     9228     +130     
==========================================
+ Hits         6398     6516     +118     
- Misses       1718     1719       +1     
- Partials      982      993      +11     
Files with missing lines Coverage Δ
crates/pop-common/src/templates/mod.rs 64.58% <100.00%> (+7.08%) ⬆️
crates/pop-parachains/src/templates.rs 98.66% <100.00%> (+0.45%) ⬆️
crates/pop-cli/src/commands/new/parachain.rs 46.31% <75.00%> (+0.18%) ⬆️
crates/pop-common/src/templates/extractor.rs 68.33% <66.66%> (ø)
crates/pop-contracts/src/new.rs 84.79% <50.00%> (+3.33%) ⬆️
crates/pop-parachains/src/up/mod.rs 87.24% <0.00%> (-0.16%) ⬇️
crates/pop-parachains/src/new_parachain.rs 77.57% <67.74%> (-4.01%) ⬇️

... and 6 files with indirect coverage changes

Base automatically changed from alex/refactor-releases to main August 27, 2024 14:02
@ozgunozerk
Copy link
Contributor

Thanks for that! Looking great to me as well

Cargo.toml Outdated Show resolved Hide resolved
@AlexD10S AlexD10S marked this pull request as ready for review September 12, 2024 11:52
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick review, a few minor comments.

crates/pop-parachains/src/new_parachain.rs Show resolved Hide resolved
crates/pop-parachains/src/templates.rs Show resolved Hide resolved
crates/pop-parachains/src/new_parachain.rs Outdated Show resolved Hide resolved
crates/pop-parachains/src/templates.rs Outdated Show resolved Hide resolved
crates/pop-parachains/src/templates.rs Outdated Show resolved Hide resolved
crates/pop-parachains/src/templates.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left a small nit :)

crates/pop-common/src/templates/mod.rs Outdated Show resolved Hide resolved
@AlexD10S AlexD10S requested a review from al3mart November 5, 2024 11:24
crates/pop-contracts/src/new.rs Outdated Show resolved Hide resolved
@al3mart al3mart merged commit fbefef6 into main Nov 8, 2024
20 checks passed
@al3mart al3mart deleted the oz-evm-template branch November 8, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants