-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration openzeppelin evm template #284
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 70.32% 70.61% +0.28%
==========================================
Files 53 54 +1
Lines 9098 9228 +130
Branches 9098 9228 +130
==========================================
+ Hits 6398 6516 +118
- Misses 1718 1719 +1
- Partials 982 993 +11
|
Thanks for that! Looking great to me as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick review, a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a small nit :)
PR to support OZ EVM template: https://github.com/OpenZeppelin/polkadot-runtime-templates/tree/main/evm-template
To support EVM chains in Zombienet, the config file includes
force_decorator = "generic-evm"
. When this field is present,pop
injectsevm_based = true
to ensure compatibility with Zombienet-SDK after the recent fix: paritytech/zombienet-sdk#256