-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local_app_process()
#43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborcsardi
force-pushed
the
feature/local
branch
2 times, most recently
from
November 13, 2020 11:32
53d038a
to
1a5b2a1
Compare
now works for me in ropensci-books/exemplighratia#4 :-) |
Doesn't quite work yet, and I'll take a different, less magical approach, so this commit is just to have a copy of the `detect_testthat_type()` function.
This is for Unix, Windows coming.
Need to stop the right app...
Just eval normally.
We'll see how well this works in practice.
gaborcsardi
force-pushed
the
feature/local
branch
from
November 14, 2020 11:57
d2408ca
to
fb2eeaf
Compare
maelle
reviewed
Nov 14, 2020
maelle
reviewed
Nov 14, 2020
maelle
reviewed
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if this could have a better name. It does not matter that much that it is a process, so we could leave that out. So maybe
local_http_server()
? Or something like that?Closes #42.