Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison for very long lines could be truncated #191

Open
olivroy opened this issue Apr 24, 2024 · 1 comment
Open

Comparison for very long lines could be truncated #191

olivroy opened this issue Apr 24, 2024 · 1 comment
Labels
feature a feature request or enhancement

Comments

@olivroy
Copy link
Contributor

olivroy commented Apr 24, 2024

old <- paste0(rep("b", length.out = 10000), collapse = "")
new <- paste0(rep("c", length.out = 10000), collapse = "")
waldo::compare(old, new)

I think the diff provided by waldo is not informative. At this point, it is only useful to know they are different.

Could this be handled?

It causes my computer to lag because testthat prints a lot of output on failed snapshot tests in gt.

See tests/testthat/_snaps/image.md. When this test fails, it is not useful to show the full diff before displaying the offer for snapshot_review(), snapshot_accept()

A change in waldo's print method would be welcome!

@hadley
Copy link
Member

hadley commented May 6, 2024

Somewhat related to #57, but not directly since here you have two very long strings that are completely different.

@hadley hadley added the feature a feature request or enhancement label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants