Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more PR links #1981

Closed
wants to merge 2 commits into from
Closed

Add more PR links #1981

wants to merge 2 commits into from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Apr 12, 2024

on main:
image

this PR:
image

Just as pr_resume() can be used as a sitrep. If cancelling, it would be possible to have a direct link to pr_resume('branch').

I also added more links to PRs in other pr functions (will test interactively in the coming days)

@@ -967,22 +969,22 @@ pr_branch_delete <- function(pr) {

if (is.null(pr_ref)) {
ui_bullets(c(
"i" = "PR {.val {pr$pr_string}} originated from branch {.val {pr_remref}},
"i" = "{.href [PR {pr$pr_string}]({pr$pr_html_url})} originated from branch {.val {pr_remref}},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"i" = "{.href [PR {pr$pr_string}]({pr$pr_html_url})} originated from branch {.val {pr_remref}},
"i" = "{.href [PR {pr$pr_number}]({pr$pr_html_url})} originated from branch {.val {pr_remref}},

This looks a bit bad.
image

Any reason on why not just including the PR Number?

)
cli::format_inline(template)
}
}
)
choice <- utils::menu(title = prompt, choices = cli::ansi_strtrim(dat_pretty))
choice <- utils::menu(title = prompt, choices = cli::ansi_strtrim(dat_pretty, width = cli::console_width() - 1L))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full width looks bad currently in RStudio (tends to switch line)

Saw the same thing in r-lib/styler#1189.

@olivroy
Copy link
Contributor Author

olivroy commented Apr 15, 2024

This is probably too verbose.

@olivroy olivroy closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant