use_github() - allow repo creation when repo is a redirect
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check name of repo against provided spec, if they are different assume it's a redirect and allow repo creation.
ateucher
changed the title
use_github() - allow repo creation when repo is a redirect
|
Is this time sensitive, i.e. needed for conf? |
|
Nope! It was for my own prep, but I just used my local branch. |
This was referenced Jul 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
check_no_github_repo()to check the name of the response from the GitHub API against the provided spec (user/repo) - If they are different it assumes it's a redirect and then proceeds and allows repo creation. It retains the behaviour where if request to the GitHub API returns a 404 it similarly passes and allows the creation of the new repo.Unfortunately the response returned from the GitHub API doesn't appear to explicitly say it's been redirected (i.e., it's a 200 HTTP code, not a 301).
Fixes #1893.
I didn't add any tests - though could add to the manual tests if you like?