Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http errors we're trying to catch for httr2 #2025

Closed
jennybc opened this issue Jul 23, 2024 · 2 comments
Closed

Update http errors we're trying to catch for httr2 #2025

jennybc opened this issue Jul 23, 2024 · 2 comments
Labels
tooling 🔨 Internal usethis tooling

Comments

@jennybc
Copy link
Member

jennybc commented Jul 23, 2024

Fragment of a slack conversation with @hadley:

... since the code was written, gh has switched from httr to httr2 so there are a few http_error_404 that should now be httr2_http_404

(I was reminded of this when looking at #1893 and #1894.)

@jennybc jennybc added the tooling 🔨 Internal usethis tooling label Jul 23, 2024
@jennybc
Copy link
Member Author

jennybc commented Jul 23, 2024

I just did a GET for a nonexistent repo and here are the classes of the error:

 - attr(*, "class")= chr [1:5] "github_error" "http_error_404" "rlang_error" "error" ...

which suggests that perhaps gh is still emitting errors with the classes we are currently expecting.

My gh version is 1.4.1, which is after the switch to httr2.

@hadley
Copy link
Member

hadley commented Jul 23, 2024

Ok we must've preserved the error classes in gh. I think we can close this then.

@jennybc jennybc closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔨 Internal usethis tooling
Projects
None yet
Development

No branches or pull requests

2 participants