Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated gha instructions/workflows for quarto #2757

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

tanho63
Copy link
Contributor

@tanho63 tanho63 commented Aug 15, 2024

Closes #2743

Updates quarto vignette and gha workflow files now that setup-r-dependencies automatically installs quarto as required.

@tanho63
Copy link
Contributor Author

tanho63 commented Aug 15, 2024

Some of the actions are failing for some reason, I think one that needs resolved in r-lib/actions?

@hadley
Copy link
Member

hadley commented Aug 15, 2024

@gaborcsardi any idea why we're missing quarto here?

@jayhesselberth
Copy link
Collaborator

You might try setting install-quarto: true in the setup-r-dependencies rule?

@tanho63
Copy link
Contributor Author

tanho63 commented Aug 15, 2024

It looks like it is already trying to install quarto. Maybe it needs a parameter to also install tinytex? (Noticed that the original workflow file calls for tinytex)
image

@jayhesselberth
Copy link
Collaborator

given tinytex was being installed by the quarto action that this PR removes, we may need to add:

- uses: r-lib/actions/setup-tinytex@v2

@jayhesselberth jayhesselberth self-requested a review August 16, 2024 15:19
Copy link
Collaborator

@jayhesselberth jayhesselberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. pkgdown needs to install tinytex to build one of the test vignettes, but most other packages shouldn't need it.

DESCRIPTION Outdated Show resolved Hide resolved
@hadley hadley merged commit f4e653a into r-lib:main Aug 16, 2024
16 checks passed
@hadley
Copy link
Member

hadley commented Aug 16, 2024

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r-lib/actions now install quarto by default
3 participants