Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback from Reviewer-1 #2664

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Address feedback from Reviewer-1 #2664

merged 10 commits into from
Oct 2, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

cf. openjournals/joss-reviews#7240 (comment)

Checking changes in .Rmd will be the easiest.

paper/paper.Rmd Outdated Show resolved Hide resolved
paper/paper.Rmd Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Collaborator

I wonder whether the reviewer intends "description of other static code analysis packages" to be other R packages, or whether it should also branch out into what linting looks like for other languages. The difficulty of linting a dynamically-typed language / relative ease of doing so for a strongly typed one is interesting, not sure if it merits mention in this particular paper. Anyway, I did find two other linting packages on CRAN worth considering:

https://cran.r-project.org/web/packages/box.linters/index.html
https://cran.r-project.org/web/packages/roxylint/index.html

Co-authored-by: Michael Chirico <[email protected]>
paper/paper.Rmd Outdated Show resolved Hide resolved

This comment was marked as off-topic.

paper/paper.Rmd Outdated Show resolved Hide resolved
paper/paper.Rmd Outdated Show resolved Hide resolved
paper/paper.Rmd Outdated Show resolved Hide resolved
IndrajeetPatil and others added 2 commits October 2, 2024 07:51
Co-authored-by: Michael Chirico <[email protected]>
@IndrajeetPatil IndrajeetPatil merged commit 1db7cc7 into main Oct 2, 2024
19 checks passed
@IndrajeetPatil IndrajeetPatil deleted the joss-review branch October 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants