Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cli error chaining + add clickable link to bad config #2602

Merged
merged 22 commits into from
Jun 17, 2024
Merged

Use cli error chaining + add clickable link to bad config #2602

merged 22 commits into from
Jun 17, 2024

Commits on Jun 11, 2024

  1. Add clickable link to config file. (could use a function to only show… 

    … basename, but still create a valid hyperlink
    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    76891df View commit details
    Browse the repository at this point in the history

  2. Rephrase message

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a0b216a View commit details
    Browse the repository at this point in the history

  3. Add call to get Error in lint() instead of Error in check_ranges()

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    48eab0d View commit details
    Browse the repository at this point in the history

  4. Reword some error messages to be more like import-standalone-types-ch… 

    …eck output https://style.tidyverse.org/error-messages.html
    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1115477 View commit details
    Browse the repository at this point in the history

  5. Add deprecation warning as a subtle footer

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b4e3574 View commit details
    Browse the repository at this point in the history

  6. Use cli parent = argument to create error messages.

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0cfb54a View commit details
    Browse the repository at this point in the history

  7. Add clickable link to culprit config file

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    60e9038 View commit details
    Browse the repository at this point in the history

  8. Update test expectations

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bb0e50e View commit details
    Browse the repository at this point in the history

  9. lint the lintr PR!

    @olivroy
    olivroy committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8ed11d4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into 2588

    @olivroy
    olivroy authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f6de328 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Remove \\ + rephrase msg + avoid creating variable

    @olivroy
    olivroy committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f2cec30 View commit details
    Browse the repository at this point in the history

  2. * only use link in malformed message. 

    * Pass call to the malformed error message (to show Error in `lint()`: instead of Error in `read_config_file()`:
* Remove conditionCall(e) since we use `parent = e`
    @olivroy
    olivroy committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0ca2b9e View commit details
    Browse the repository at this point in the history

  3. Adjust different wording for missing argument

    @olivroy
    olivroy committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    60eb6de View commit details
    Browse the repository at this point in the history

  4. Add file name to config error msg

    @olivroy
    olivroy committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d25064b View commit details
    Browse the repository at this point in the history

  5. read_settings() is an exported function, it shouldn't have a call… 

    … argument.

Config error will therefore read as

Error in `read_settings()`: instead of Error in `lint()`:
    @olivroy
    olivroy committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    07a96a0 View commit details
    Browse the repository at this point in the history

  6. lint

    @olivroy
    olivroy committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e9a4292 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Michael Chirico <[email protected]>
    @olivroy @MichaelChirico
    olivroy and MichaelChirico authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    032404e View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Address comment

    @olivroy
    olivroy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ef82536 View commit details
    Browse the repository at this point in the history

  2. Add back call to read_settings() for for better trace.

    @olivroy
    olivroy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    40728d6 View commit details
    Browse the repository at this point in the history

  3. Merged upstream/main into 2588

    @olivroy
    olivroy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f4cccea View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merged upstream/main into 2588

    @olivroy
    olivroy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    71afff3 View commit details
    Browse the repository at this point in the history

  2. Move link creation to link_config_file()

    @olivroy
    olivroy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    308188d View commit details
    Browse the repository at this point in the history