Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest major {withr} version #2583

Closed
wants to merge 1 commit into from
Closed

Conversation

IndrajeetPatil
Copy link
Collaborator

To benefit from performance and other enhancements in this release: https://www.tidyverse.org/blog/2024/01/withr-3-0-0/

We have already fixed issues stemming from this version: #2519

We didn't bump the version because it was quite new at the time, but we can do so now.

To benefit from performance and other enhancements in this release: https://www.tidyverse.org/blog/2024/01/withr-3-0-0/
@MichaelChirico
Copy link
Collaborator

Sorry, I don't see why we should increase the minimum version dependency unless we actually use something from that version?

If some user can't upgrade {withr}, why should we prevent them from using {lintr} unless there's something specific in the new version that we "need" for {lintr}?

I must be missing something...

@IndrajeetPatil
Copy link
Collaborator Author

If some user can't upgrade {withr}, why should we prevent them from using {lintr}

But it's not a runtime dependency of {lintr}. Why would it prevent them from using {lintr}?

@IndrajeetPatil
Copy link
Collaborator Author

At any rate, this is not critical. withr 3.0.0 was quite an extensive rewrite, and I would have liked for us to see some of its benefits in our dev workflow (performance, better messages, etc.).

Maybe working on #2539 will help motivate this further.

@IndrajeetPatil IndrajeetPatil deleted the use-latest-withr branch May 23, 2024 20:04
@IndrajeetPatil IndrajeetPatil restored the use-latest-withr branch May 23, 2024 20:05
@IndrajeetPatil IndrajeetPatil deleted the use-latest-withr branch May 23, 2024 20:05
@MichaelChirico
Copy link
Collaborator

But it's not a runtime dependency of {lintr}. Why would it prevent them from using {lintr}?

True, but all the more reason not to enforce a minimum version IMO.

If there's some actual code changes you want to make that use updated functionality, I am happy to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants