Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL order in DESCRIPTION to be pkgdown-friendly #2561

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

  • On main:
downlit:::autolink_curly("{lintr}")
#> "<a href='https://github.com/r-lib/lintr'>lintr</a>"
  • On current branch:
downlit:::autolink_curly("{lintr}")
#> "<a href='https://lintr.r-lib.org'>lintr</a>"

@MichaelChirico
Copy link
Collaborator

Confirming the real workhorse here:

https://github.com/r-lib/downlit/blob/c0a8f645e21a03e258b7c1684901f84279cc706a/R/link.R#L338-L345
https://github.com/r-lib/downlit/blob/c0a8f645e21a03e258b7c1684901f84279cc706a/R/metadata.R#L98

I.e., it literally pulls the 1st entry from the URL key in DCF.

I was wondering if there might be a more specific key we could use instead, e.g. Config/pkgdown/url or something.

@MichaelChirico
Copy link
Collaborator

Nice find!

@MichaelChirico MichaelChirico merged commit 28166bf into main Apr 22, 2024
20 checks passed
@MichaelChirico MichaelChirico deleted the change-desc-url-order branch April 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants