Catch unreadable files early with warning

[MichaelChirico]

Closes #1939

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccdb186) 98.54% compared to head (033150e) 98.55%.
Report is 2 commits behind head on main.

❗ Current head 033150e differs from pull request most recent head 05877ae. Consider uploading reports for the commit 05877ae to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2506   +/-   ##
=======================================
  Coverage   98.54%   98.55%           
=======================================
  Files         126      126           
  Lines        5720     5729    +9     
=======================================
+ Hits         5637     5646    +9     
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AshesITR]

Why should we just warn instead of stopping?

[MichaelChirico]

Why should we just warn instead of stopping?

what I had in mind is a directory of scripts where one doesn't have the right permissions. Better to just skip the one file than stop midway.

[AshesITR]

Seems to me that access rights should then be checked by lint_dir instead of lint.

[MichaelChirico]

Seems to me that access rights should then be checked by lint_dir instead of lint.

maybe, but after #2135 it will wind up back in lint() I reckon.

Shall we table this PR for now then?

[AshesITR]

Not sure that will happen, actually.
But sounds okay if there is no immediate pain.

Even with vectorized lint I feel access checking doesn't belong there. lint_dir(path, skip_inaccessible = TRUE), which should be non-default imo, could do files <- files[vapply(files, \(x) file.access(x, 4L) != -1, logical(1L))] if requested by the caller.