Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following expr can be other expr-ish nodes in consecutive_assertion_linter() #2454

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2444

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2428646) 98.52% compared to head (add1f63) 98.52%.
Report is 1 commits behind head on main.

❗ Current head add1f63 differs from pull request most recent head 35b438c. Consider uploading reports for the commit 35b438c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2454   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files         126      126           
  Lines        5638     5639    +1     
=======================================
+ Hits         5555     5556    +1     
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR
Copy link
Collaborator

LGTM. Ping when ready to merge this one.

@MichaelChirico
Copy link
Collaborator Author

g2g here

@AshesITR AshesITR merged commit fdbb9bf into main Dec 15, 2023
21 checks passed
@MichaelChirico MichaelChirico deleted the assert-eq branch December 27, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consecutive_assertion_linter() gives false positive when interceded by '=' assignment
3 participants