Convert todo_comment_linter to XPath approach #2438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
==========================================
- Coverage 98.54% 98.52% -0.02%
==========================================
Files 126 126
Lines 5633 5627 -6
==========================================
- Hits 5551 5544 -7
- Misses 82 83 +1 ☔ View full report in Codecov by Sentry. |
R/todo_comment_linter.R
Outdated
| ) | ||
| } | ||
|
|
||
| Linter(linter_level = "file", function(source_expression) { |
There was a problem hiding this comment.
Why apply this on the file-level?
There was a problem hiding this comment.
I was thinking there's not much benefit to being expression-level for what's basically a simple text-match linter. But there might be a ton of comments in a huge file, so maybe caching would help.
There was a problem hiding this comment.
I'm thinking we should specify the lowest cacheable level, which should be expression here.
I have an idea cooking on how to speed up expression-level linters by running them on the file-level if they support it and being smart about the caching. But that's not completely ripe yet.
There was a problem hiding this comment.
sounds exciting. I think something like this is definitely possible and would be a big boon to anyone who never caches (like me 😅)
Follow-up to #2437, towards #2047.