Support pattern-based exclusion in return_linter() #2433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2335.
Implementation is maybe not ideal since it requires running the
//FUNCTION | //OP-LAMBDA
XPath twice -- once to find the names of assigned functions, a second time to check for lints.The workaround I could think of was to (1) find all
//FUNCTION | //OP-LAMBDA
nodes (2) partition into assigned vs. unassigned (3) trimexcept|except_regex
from the assigned group (4)combine_nodesets()
(4) check for lints. But IINM this would require refactoring a lot of other code as well, I'm not sure it's worth it --//FUNCTION | //OP-LAMBDA
should be relatively fast.