Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize lint message for nzchar_linter() #2420

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Customize lint message for nzchar_linter() #2420

merged 7 commits into from
Dec 13, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2383

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tests/testthat/test-nzchar_linter.R Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (538440d) 98.53% compared to head (99cd756) 98.54%.

❗ Current head 99cd756 differs from pull request most recent head 8bc2d23. Consider uploading reports for the commit 8bc2d23 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2420   +/-   ##
=======================================
  Coverage   98.53%   98.54%           
=======================================
  Files         125      125           
  Lines        5609     5631   +22     
=======================================
+ Hits         5527     5549   +22     
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil
Copy link
Collaborator

Overall, this looks good! Thanks.

While you are at nzchar_linter(), can you please also update the examples to follow the same pattern we are following in other linters (parallel examples that do and don't lint)?

@AshesITR AshesITR merged commit 3fae957 into main Dec 13, 2023
21 checks passed
@AshesITR AshesITR deleted the nz-cust branch December 13, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing (misleading?) lint message from nzchar_linter()
4 participants