Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle comparison to negative non-integer in expect_identical_linter #2411

Merged
merged 14 commits into from
Jun 8, 2024
Merged

Handle comparison to negative non-integer in expect_identical_linter #2411

merged 14 commits into from
Jun 8, 2024

Commits on Jun 7, 2024

  1. Add test for r-lib#2410

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    57ed4e2 View commit details
    Browse the repository at this point in the history

  2. Add branch for negative non-integer values

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    373e02c View commit details
    Browse the repository at this point in the history

  3. Add NEWS bullet

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4a5cf12 View commit details
    Browse the repository at this point in the history

  4. Add test for review comment

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9f5c857 View commit details
    Browse the repository at this point in the history

  5. Add more tests

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    bec2686 View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    02ea71d View commit details
    Browse the repository at this point in the history

  7. Add more context to NEWS 

    Co-authored-by: Michael Chirico <[email protected]>
    @Bisaloo @MichaelChirico
    Bisaloo and MichaelChirico committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    3d8f027 View commit details
    Browse the repository at this point in the history

  8. Factor following-sibling::expr in XPath

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    75a04dd View commit details
    Browse the repository at this point in the history

  9. Add tests c() and OP-MINUS combined

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    df79a10 View commit details
    Browse the repository at this point in the history

  10. Handle expect_equal(x, -c(1.034))

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fc73416 View commit details
    Browse the repository at this point in the history

  11. Handle expect_equal(x, c(-1.034))

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    84ddefd View commit details
    Browse the repository at this point in the history

  12. Factor out non_integer & non_integer_negative xpaths

    @Bisaloo
    Bisaloo committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9c1aa38 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Handle both positive and negative case in non_integer

    @Bisaloo
    Bisaloo committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    36a8c0c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into negative-expect-equal

    @IndrajeetPatil
    IndrajeetPatil authored Jun 8, 2024
    Configuration menu
    Copy the full SHA
    79334a8 View commit details
    Browse the repository at this point in the history