Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to read_settings() #2270

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Link to read_settings() #2270

merged 3 commits into from
Nov 10, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Nov 10, 2023

Link to read_settings() where settings search order is defined. Plus some cosmetic changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023 •
edited
Loading

Codecov Report

Merging #2270 (12ccdab) into main (3cf68db) will not change coverage.
The diff coverage is n/a.

❗ Current head 12ccdab differs from pull request most recent head 9d4e0f8. Consider uploading reports for the commit 9d4e0f8 to get more accurate results

@@           Coverage Diff           @@
##             main    #2270   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         114      114           
  Lines        5235     5235           
=======================================
  Hits         5216     5216           
  Misses         19       19
Files Coverage Δ
R/lint.R 98.79% <ø> (ø)
R/settings.R 98.34% <ø> (ø)

IndrajeetPatil
IndrajeetPatil requested changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also roxygenize so that these changes are reflected in the .Rd files?

@salim-b
Copy link
Contributor Author

salim-b commented Nov 10, 2023

Aight, done.

IndrajeetPatil
IndrajeetPatil approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IndrajeetPatil IndrajeetPatil merged commit b44f625 into r-lib:main Nov 10, 2023
20 checks passed
@salim-b salim-b deleted the patch-1 branch November 10, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IndrajeetPatil IndrajeetPatil IndrajeetPatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salim-b @codecov-commenter @IndrajeetPatil