Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set structure() as an undesirable function by default #2228

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Oct 4, 2023

Follow-up to #2227

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #2228 (0259566) into main (9c49c6e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 0259566 differs from pull request most recent head 120a3c3. Consider uploading reports for the commit 120a3c3 to get more accurate results

@@           Coverage Diff           @@
##             main    #2228   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         114      114           
  Lines        5173     5175    +2     
=======================================
+ Hits         5155     5157    +2     
  Misses         18       18           
Files Coverage Δ
R/utils.R 99.13% <100.00%> (+0.01%) ⬆️
R/zzz.R 100.00% <ø> (ø)

@AshesITR
Copy link
Collaborator

AshesITR commented Oct 4, 2023

For the "by default" part, you need to add it to default_undesirable_functions as well 😉

R/zzz.R Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

AshesITR commented Oct 4, 2023

LGTM holding off merging until NEWS is up to speed so we can't forget the bullet.

.lintr Show resolved Hide resolved
R/zzz.R Show resolved Hide resolved
@AshesITR AshesITR merged commit b49ee9d into main Oct 5, 2023
20 checks passed
@AshesITR AshesITR deleted the structure-undesirable branch October 5, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants