Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract XML-related utilities into a separate file #2201

Merged
merged 6 commits into from
May 25, 2024
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Since the utils.R is getting quite large.

Similar to xp_utils.R.

Since the `utils.R` is getting quite large.

Similar to `xp_utils.R`.
@MichaelChirico
Copy link
Collaborator

I would let this PR simmer a while. There's some cost to understanding git history when moving code between files like this. If there will only ever be two functions in the new utils file, I'm not sure it's worth it.

It might be more fruitful to group some of the other utils together, or to try removing some of them.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (fc2268f) to head (698eb8f).
Report is 3 commits behind head on main.

Current head 698eb8f differs from pull request most recent head b07db9a

Please upload reports for the commit b07db9a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   98.15%   99.63%   +1.48%     
==========================================
  Files         125      115      -10     
  Lines        5738     5235     -503     
==========================================
- Hits         5632     5216     -416     
+ Misses        106       19      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 7f6687c into main May 25, 2024
20 checks passed
@IndrajeetPatil IndrajeetPatil deleted the xml-utils branch May 25, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants