Skip to content

Commit

Permalink
Remove unicode tests because they break in different locales.
Browse files Browse the repository at this point in the history
  • Loading branch information
jimhester committed Nov 28, 2014
1 parent 01849a5 commit a039420
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 27 deletions.
17 changes: 1 addition & 16 deletions tests/testthat/test-assignment_linter.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
context("assignment_linter")
options(encoding = "UTF-8")
test_that("returns the correct linting", {
expect_lint("blah", NULL, assignment_linter)

Expand Down Expand Up @@ -31,20 +32,4 @@ test_that("returns the correct linting", {
rex("Use <-, not =, for assignment."),
assignment_linter)

test_that("handles unicode characters correctly", {
expect_lint("Ħ = 1",
list(c(column_number = 3L)),
assignment_linter)

expect_lint("Ħ = 1;aèn = 2",
list(c(column_number = 3L),
c(column_number = 11L)),
assignment_linter)

expect_lint("a = 1;aèn = 2",
list(c(column_number = 3L),
c(column_number = 11L)),
assignment_linter)

})
})
11 changes: 0 additions & 11 deletions tests/testthat/test-line_length_linter.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,3 @@ test_that("returns the correct linting", {
rex("lines should not be more than 20 characters"),
line_length_linter(20))
})
test_that("works with unicode characters", {

expect_lint("'☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂'",
NULL,
line_length_linter(20))

expect_lint("'☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂☂'",
rex("lines should not be more than 20 characters"),
line_length_linter(20))

})

0 comments on commit a039420

Please sign in to comment.