Avoid the version number in checkstyle tests

r-lib · Oct 11, 2022 · 4b051fc · 4b051fc
1 parent f904ff8
commit 4b051fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/testthat/checkstyle.xml b/tests/testthat/checkstyle.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<checkstyle version="lintr-3.0.1">
+<checkstyle version="lintr-x.y.z">
  <file name="test_file">
  <error line="1" column="2" severity="error" message="foo"/>
  <error line="2" column="1" severity="info" message="bar"/>

diff --git a/tests/testthat/test-checkstyle_output.R b/tests/testthat/test-checkstyle_output.R
@@ -24,5 +24,7 @@ test_that("return lint report as checkstyle xml", {
  tmp <- tempfile()
  checkstyle_output(lints, tmp)
 
- expect_equal(readLines(tmp), readLines("checkstyle.xml"))
+ # The second line is the checkstyle version, so we ignore it during the
+ # check, so we don't have to update the version every release.
+ expect_equal(readLines(tmp)[-2], readLines("checkstyle.xml")[-2])
 })