Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage our own pushback state #535

Merged
merged 22 commits into from
Sep 6, 2024
Merged

Manage our own pushback state #535

merged 22 commits into from
Sep 6, 2024

Commits on Sep 4, 2024

  1. Manage our own pushback state 

    Fixes #532
    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4ed3709 View commit details
    Browse the repository at this point in the history

  2. Add test for non-blocking case 

    And make some testing improvements
    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2e2dc82 View commit details
    Browse the repository at this point in the history

  3. WS

    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    976e9f0 View commit details
    Browse the repository at this point in the history

  4. Correctly close connection

    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    edd1fec View commit details
    Browse the repository at this point in the history

  5. Consistently use defer() in tests

    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6902d76 View commit details
    Browse the repository at this point in the history

  6. More robust waiting

    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    32f2553 View commit details
    Browse the repository at this point in the history

  7. Merged origin/main into manual-pushback

    @hadley
    hadley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3e3b0d8 View commit details
    Browse the repository at this point in the history

  8. Add (failing) edge case to sse unit test

    @jcheng5
    jcheng5 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    96d96a6 View commit details
    Browse the repository at this point in the history

  9. Perform all SSE boundary detection in binary

    @jcheng5
    jcheng5 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7b3fc7a View commit details
    Browse the repository at this point in the history

  10. Refactor resp_stream_sse to not read the connection until it's needed

    @jcheng5
    jcheng5 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    578949b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. while (TRUE) -> repeat 

    Co-authored-by: Hadley Wickham <[email protected]>
    @jcheng5 @hadley
    jcheng5 and hadley authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    234fbde View commit details
    Browse the repository at this point in the history

  2. Implement max_size for sse

    @jcheng5
    jcheng5 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a849d0c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Make sure req_perform_stream always returns complete lines

    @jcheng5
    jcheng5 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6539d2f View commit details
    Browse the repository at this point in the history

  2. Respect lines argument of resp_stream_lines

    @jcheng5
    jcheng5 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    03c5c32 View commit details
    Browse the repository at this point in the history

  3. Make resp_boundary_pushback consistently return NULL on EOL, never ch… 

    …aracter(0)
    @jcheng5
    jcheng5 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    99171c8 View commit details
    Browse the repository at this point in the history

  4. Make resp_stream_lines respect encoding

    @jcheng5
    jcheng5 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    84252a9 View commit details
    Browse the repository at this point in the history

  5. Spread code across more files

    @hadley
    hadley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    bf417ec View commit details
    Browse the repository at this point in the history

  6. Add more tests and fix problem thus revealed

    @hadley
    hadley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2da3a30 View commit details
    Browse the repository at this point in the history

  7. Reorg

    @hadley
    hadley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6c82923 View commit details
    Browse the repository at this point in the history

  8. Correct test/code some more

    @hadley
    hadley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    52f629a View commit details
    Browse the repository at this point in the history

  9. Extract out helper to make coverage easier 

    Fixes #544
    @hadley
    hadley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    df308b6 View commit details
    Browse the repository at this point in the history

  10. Merge commit 'a241b04b079c5a76a04e5ac449c0612c99e0fd00'

    @hadley
    hadley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    08c102f View commit details
    Browse the repository at this point in the history